Issue 12038038: Add support for specifying SDK version constraints in pubspecs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12038038: Add support for specifying SDK version constraints in pubspecs. (Closed)

Created:
7 years, 11 months ago by Bob Nystrom

Modified:
7 years, 11 months ago

Reviewers:
Alan Knight

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add support for specifying SDK version constraints in pubspecs. These constraints don't currently do anything, but these patch gets them being parsed by pub. Committed: https://code.google.com/p/dart/source/detail?r=17477

Patch Set 1 #

Patch Set 2 : Clean up a bit. #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+167 lines, -27 lines)			Patch
M	utils/pub/pubspec.dart	View	1	5 chunks	+38 lines, -3 lines	0 comments	Download
M	utils/pub/sdk_source.dart	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	utils/pub/version.dart	View		4 chunks	+12 lines, -5 lines	0 comments	Download
M	utils/tests/pub/command_line_config.dart	View		5 chunks	+55 lines, -16 lines	0 comments	Download
M	utils/tests/pub/pubspec_test.dart	View	1	2 chunks	+44 lines, -0 lines	0 comments	Download
M	utils/tests/pub/version_solver_test.dart	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	utils/tests/pub/version_test.dart	View	1	2 chunks	+14 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

Hi, Alan! Nathan is out this week. Want to be a pub code reviewer?

7 years, 11 months ago (2013-01-23 00:39:12 UTC) #1

lgtm

Expand Messages | Collapse Messages