Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1221)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12038036: SVG Library cleanups and adding supported tag. (Closed)

Created:
7 years, 11 months ago by Emily Fortuna
Modified:
7 years, 10 months ago
Reviewers:
blois
CC:
reviews_dartlang.org
Visibility:
Public.

Description

SVG Library cleanups and adding supported tag. BUG= Committed: https://code.google.com/p/dart/source/detail?r=17940

Patch Set 1 : #

Total comments: 6

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2651 lines, -1732 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 4 chunks +107 lines, -107 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 5 chunks +133 lines, -132 lines 0 comments Download
M sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/indexed_db/dartium/indexed_db_dartium.dart View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M sdk/lib/svg/dart2js/svg_dart2js.dart View 1 2 3 42 chunks +704 lines, -433 lines 0 comments Download
M sdk/lib/svg/dartium/svg_dartium.dart View 1 2 3 42 chunks +780 lines, -517 lines 0 comments Download
M tests/html/html.status View 1 2 3 5 chunks +43 lines, -14 lines 0 comments Download
D tests/html/svg_1_test.dart View 1 chunk +0 lines, -46 lines 0 comments Download
D tests/html/svg_2_test.dart View 1 2 3 1 chunk +0 lines, -65 lines 0 comments Download
D tests/html/svg_3_test.dart View 1 2 3 1 chunk +0 lines, -129 lines 0 comments Download
A tests/html/svg_test.dart View 1 2 3 1 chunk +247 lines, -0 lines 0 comments Download
M tests/html/svgelement2_test.dart View 2 chunks +10 lines, -6 lines 0 comments Download
M tests/html/svgelement_test.dart View 1 chunk +298 lines, -108 lines 0 comments Download
M tools/dom/scripts/generator.py View 1 2 3 7 chunks +44 lines, -23 lines 0 comments Download
M tools/dom/scripts/htmldartgenerator.py View 1 1 chunk +8 lines, -3 lines 0 comments Download
M tools/dom/scripts/htmlrenamer.py View 1 2 3 2 chunks +36 lines, -8 lines 0 comments Download
M tools/dom/scripts/monitored.py View 1 chunk +3 lines, -0 lines 0 comments Download
M tools/dom/scripts/systemhtml.py View 1 2 3 5 chunks +221 lines, -137 lines 0 comments Download
M tools/dom/scripts/systemnative.py View 1 1 chunk +5 lines, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_SVGElement.darttemplate View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Emily Fortuna
It's the CL you've been waiting for! https://codereview.chromium.org/12038036/diff/14001/tests/html/svg_test.dart File tests/html/svg_test.dart (right): https://codereview.chromium.org/12038036/diff/14001/tests/html/svg_test.dart#newcode12 tests/html/svg_test.dart:12: useHtmlIndividualConfiguration(); now ...
7 years, 11 months ago (2013-01-24 21:55:17 UTC) #1
blois
Quick glance, couldn't quite decipher the supported syntax. Tests don't appear to run? https://codereview.chromium.org/12038036/diff/14001/tests/html/svg_test.dart File ...
7 years, 11 months ago (2013-01-24 23:20:46 UTC) #2
Emily Fortuna
ptal.
7 years, 10 months ago (2013-01-30 21:24:12 UTC) #3
blois
7 years, 10 months ago (2013-01-31 19:18:37 UTC) #4 
lgtm

Powered by Google App Engine
This is Rietveld 408576698