Issue 12038018: Disallow mixing in classes that have constructors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12038018: Disallow mixing in classes that have constructors. (Closed)

Created:
7 years, 11 months ago by kasperl

Modified:
7 years, 11 months ago

Reviewers:
Johnni Winther

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Disallow mixing in classes that have constructors. R=johnniwinther@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=17389

Patch Set 1 #

Total comments: 2

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+97 lines, -10 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/resolution/members.dart	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/warnings.dart	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	tests/language/language.status	View	4 chunks	+29 lines, -10 lines	0 comments	Download
A	tests/language/mixin_illegal_constructor_test.dart	View	1 chunk	+55 lines, -0 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Johnni Winther

lgtm https://codereview.chromium.org/12038018/diff/1/tests/language/mixin_illegal_constructor_test.dart File tests/language/mixin_illegal_constructor_test.dart (right): https://codereview.chromium.org/12038018/diff/1/tests/language/mixin_illegal_constructor_test.dart#newcode4 tests/language/mixin_illegal_constructor_test.dart:4: There is no case where the constructor is ...

7 years, 11 months ago (2013-01-22 11:46:44 UTC) #2

kasperl

7 years, 11 months ago (2013-01-22 11:50:45 UTC) #3

https://codereview.chromium.org/12038018/diff/1/tests/language/mixin_illegal_...
File tests/language/mixin_illegal_constructor_test.dart (right):

https://codereview.chromium.org/12038018/diff/1/tests/language/mixin_illegal_...
tests/language/mixin_illegal_constructor_test.dart:4: 
On 2013/01/22 11:46:44, Johnni Winther wrote:
> There is no case where the constructor is synthesized.

Well, that is generally the case for mixins so that should be well covered by
all the positive test cases.

Expand Messages | Collapse Messages