Issue 12036101: Add more tests and fix the parser to deal with generic superclasses for mixin applications.

Issue 12036101: Add more tests and fix the parser to deal with generic superclasses for mixin applications. (Closed)

Created:
7 years, 11 months ago by kasperl

Modified:
7 years, 11 months ago

Reviewers:
ahe, karlklose

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add more tests and fix the parser to deal with generic superclasses for mixin applications. R=ahe@google.com,karlklose@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=17635

Patch Set 1 #

Total comments: 2

Patch Set 2 : Less indentation. #

Patch Set 3 : Remove newline. #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+108 lines, -90 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/scanner/parser.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/language/language.status	View	1 2	2 chunks	+20 lines, -14 lines	0 comments	Download
M	tests/language/language_dart2js.status	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	tests/language/mixin_illegal_syntax_test.dart	View		5 chunks	+9 lines, -0 lines	0 comments	Download
A +	tests/language/mixin_type_parameters_mixin_extends_test.dart	View		2 chunks	+36 lines, -36 lines	0 comments	Download
A +	tests/language/mixin_type_parameters_mixin_test.dart	View		2 chunks	+35 lines, -35 lines	0 comments	Download
A +	tests/language/mixin_type_parameters_super_extends_test.dart	View		1 chunk	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kasperl

On 2013/01/25 10:09:07, ahe wrote: > LGTM > > Which test is passing now that ...

7 years, 11 months ago (2013-01-25 10:11:38 UTC) #3

karlklose

7 years, 11 months ago (2013-01-25 10:12:47 UTC) #4

LGTM.

https://codereview.chromium.org/12036101/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/scanner/parser.dart (right):

https://codereview.chromium.org/12036101/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/scanner/parser.dart:494: token =
parseMixinApplication(token.next);
Remove whitespace.

https://codereview.chromium.org/12036101/diff/1/tests/language/language.status
File tests/language/language.status (right):

https://codereview.chromium.org/12036101/diff/1/tests/language/language.statu...
tests/language/language.status:77: 
Remove extra line?

Expand Messages | Collapse Messages