First set of changes towards cleaning up the bytearray access APIs

First set of changes towards cleaning up the bytearray access APIs
- Added unimplemented versions of Dart_ByteArrayAcquireData and
  Dart_ByteArrayReleaseData
- Added infrastructure to prevent callbacks into an API function that
  allocates a new object on the Dart heap or invokes dart code.
- Removed the old Dart_ByteArrayGet* access functions as it was felt that
  they have become redundant once we provide direct access to the internal
  data pointers.
- Removed DARTSCOPE_NOCHECKS as it seems to be redundant after the change
  to not create explicit stack zones on each Dart API call.
Committed: https://code.google.com/p/dart/source/detail?r=17958

[Tom Ball, 2013-01-25 02:13:47]

Looks good so far, couldn't find any mistakes.

Since this API exposes raw arrays to clients, I think in debug mode this API
should pad the beginning and end with sentinel values, and have the array access
functions verify they weren't modified.

[Anton Muhin, 2013-01-25 13:11:53]

https://chromiumcodereview.appspot.com/12036098/diff/7001/include/dart_api.h
File include/dart_api.h (right):

https://chromiumcodereview.appspot.com/12036098/diff/7001/include/dart_api.h#...
include/dart_api.h:1737: DART_EXPORT Dart_Handle
Dart_ByteArrayAcquireData(Dart_Handle array,
Maybe something like ScalarList instead of ByteArray as ByteArray is already an
interface name.

[siva, 2013-01-25 17:54:15]

https://chromiumcodereview.appspot.com/12036098/diff/7001/include/dart_api.h
File include/dart_api.h (right):

https://chromiumcodereview.appspot.com/12036098/diff/7001/include/dart_api.h#...
include/dart_api.h:1737: DART_EXPORT Dart_Handle
Dart_ByteArrayAcquireData(Dart_Handle array,
Agree will change all the ByteArray calls to ScalarList
(Won't change the existing ones in this CL but will do it
in a subsequent one).

On 2013/01/25 13:11:53, Anton Muhin wrote:
> Maybe something like ScalarList instead of ByteArray as ByteArray is already
an
> interface name.

[Ivan Posva, 2013-01-29 01:54:03]

LGTM with a couple of comments.

-Ivan

https://codereview.chromium.org/12036098/diff/11002/include/dart_api.h
File include/dart_api.h (right):

https://codereview.chromium.org/12036098/diff/11002/include/dart_api.h#newcod...
include/dart_api.h:1706: typedef enum {
Move this up to the beginning of the scalar list section. It will be needed as
part of creating new scalar lists.

https://codereview.chromium.org/12036098/diff/11002/vm/dart_api_impl.cc
File vm/dart_api_impl.cc (right):

https://codereview.chromium.org/12036098/diff/11002/vm/dart_api_impl.cc#newco...
vm/dart_api_impl.cc:2306: CHECK_CALLBACK_STATE(isolate);
Is there a way to make sure that this macro was added for all code that can
allocate or call into Dart?

https://codereview.chromium.org/12036098/diff/11002/vm/dart_api_impl.h
File vm/dart_api_impl.h (right):

https://codereview.chromium.org/12036098/diff/11002/vm/dart_api_impl.h#newcod...
vm/dart_api_impl.h:107: // Sets up the callback error object after initializing
an Isolate. This
Can this callback error object be pre-allocated in the VM isolate?

[siva, 2013-01-31 01:54:45]

https://codereview.chromium.org/12036098/diff/11002/include/dart_api.h
File include/dart_api.h (right):

https://codereview.chromium.org/12036098/diff/11002/include/dart_api.h#newcod...
include/dart_api.h:1706: typedef enum {
On 2013/01/29 01:54:03, Ivan Posva wrote:
> Move this up to the beginning of the scalar list section. It will be needed as
> part of creating new scalar lists.

Done.

https://codereview.chromium.org/12036098/diff/11002/vm/dart_api_impl.cc
File vm/dart_api_impl.cc (right):

https://codereview.chromium.org/12036098/diff/11002/vm/dart_api_impl.cc#newco...
vm/dart_api_impl.cc:2306: CHECK_CALLBACK_STATE(isolate);
On 2013/01/29 01:54:03, Ivan Posva wrote:
> Is there a way to make sure that this macro was added for all code that can
> allocate or call into Dart?

I have added an assert in the 3 entrypoints to dart and in Object::Allocate (I
don't think c++ code uses the inline allocations stubs so we should be covered).

https://codereview.chromium.org/12036098/diff/11002/vm/dart_api_impl.h
File vm/dart_api_impl.h (right):

https://codereview.chromium.org/12036098/diff/11002/vm/dart_api_impl.h#newcod...
vm/dart_api_impl.h:107: // Sets up the callback error object after initializing
an Isolate. This
I believe it should be possible to do that, currently null, true, false and this
new object are set up on a per isolate basis. In a separate CL I will make these
handles static fields and initialize them in the VM isolate.

On 2013/01/29 01:54:03, Ivan Posva wrote:
> Can this callback error object be pre-allocated in the VM isolate?