Issue 12036060: Fixing tests after event constructor change.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12036060: Fixing tests after event constructor change. (Closed)

Created:
7 years, 11 months ago by blois

Modified:
7 years, 11 months ago

Reviewers:
Emily Fortuna

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fixing tests after event constructor change. This broke Dartium because apparently Dartium has different validation on parameters (opened bug 8076). Also fixed the history test on IE, since the HashChangeEvent is not working there. TBR BUG= Committed: https://code.google.com/p/dart/source/detail?r=17494

Patch Set 1 #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -7 lines)			Patch
M	tests/html/history_test.dart	View	1 chunk	+6 lines, -4 lines	0 comments	Download
M	tests/html/serialized_script_value_test.dart	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	tests/html/storage_test.dart	View	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages