Issue 12036009: Add a test that native classes work with operator==.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12036009: Add a test that native classes work with operator==. (Closed)

Created:
7 years, 11 months ago by ngeoffray

Modified:
7 years, 11 months ago

Reviewers:
ahe

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Add a test that native classes work with operator==. Committed: https://code.google.com/p/dart/source/detail?r=17350

Patch Set 1 #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -2 lines)			Patch
	A +	tests/compiler/dart2js_native/native_equals_frog_test.dart	View		2 chunks	+7 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ahe

LGTM. Perhaps you should rename the test. If you think it is legacy support, you ...

7 years, 11 months ago (2013-01-21 13:04:57 UTC) #2

ngeoffray

On 2013/01/21 13:04:57, ahe wrote: > LGTM. Thanks Peter. > > Perhaps you should rename ...

7 years, 11 months ago (2013-01-21 13:06:16 UTC) #3

sra1

7 years, 11 months ago (2013-01-22 03:21:40 UTC) #4

Message was sent while issue was closed.

On 2013/01/21 13:06:16, ngeoffray wrote:
> On 2013/01/21 13:04:57, ahe wrote:
> > LGTM.
> 
> Thanks Peter.
> 
> > 
> > Perhaps you should rename the test. If you think it is legacy support, you
> could
> > call it "legacy".
> 
> It's not legacy, as we need to have native classes understand operator==. We
> should remove 'frog' names from all tests within this directory.

+1 on removing '_frog' from the names, but I suggest a separate CL.
We have been deleting tests as they become unnecessary.

Expand Messages | Collapse Messages