Issue 12036005: Allow cascades in initializer lists.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12036005: Allow cascades in initializer lists. (Closed)

Created:
7 years, 11 months ago by Kevin Millikin (Google)

Modified:
7 years, 11 months ago

Reviewers:
Vyacheslav Egorov (Google), hausner

CC:
reviews_dartlang.org, Vyacheslav Egorov (Google)

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Allow cascades in initializer lists. BUG= Committed: https://code.google.com/p/dart/source/detail?r=17383

Patch Set 2 : Added a simple test. #

Patch Set 3 : Remove inadvertently pasted comment. #

Total comments: 2

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -11 lines)			Patch
	M	runtime/vm/parser.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download
	A +	tests/language/cascade_in_initializer_list_test.dart	View	1 2	1 chunk	+10 lines, -11 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Google)

Test added. https://codereview.chromium.org/12036005/diff/1002/tests/language/cascade_in_initializer_list_test.dart File tests/language/cascade_in_initializer_list_test.dart (right): https://codereview.chromium.org/12036005/diff/1002/tests/language/cascade_in_initializer_list_test.dart#newcode1 tests/language/cascade_in_initializer_list_test.dart:1: // Copyright (c) 2013, the Dart project ...

7 years, 11 months ago (2013-01-21 12:07:48 UTC) #3

hausner

7 years, 11 months ago (2013-01-22 05:49:36 UTC) #4

LGTM, thanks for fixing!

https://codereview.chromium.org/12036005/diff/1002/tests/language/cascade_in_...
File tests/language/cascade_in_initializer_list_test.dart (right):

https://codereview.chromium.org/12036005/diff/1002/tests/language/cascade_in_...
tests/language/cascade_in_initializer_list_test.dart:1: // Copyright (c) 2013,
the Dart project authors.  Please see the AUTHORS file
On 2013/01/21 12:07:48, kmillikin wrote:
> Hilariously, Rietveld thinks this new file is a diff against
>
https://code.google.com/p/dart/source/diff?spec=svn16957&r=16957&format=side&...

Thanks for this heads-up, I was quite confused :)