Verify integrity of JSOM messages sent to debugger client

Verify integrity of JSOM messages sent to debugger client

Make sure JSOM messages are grammatically correct and string values are properly encoded.
Committed: https://code.google.com/p/dart/source/detail?r=17617

[Tom Ball, 2013-01-24 23:28:23]

LGTM

I'm surprised we aren't using an existing open-source library, like libjson.
Regardless, your changes look fine.

https://codereview.chromium.org/12035086/diff/2003/runtime/platform/json.cc
File runtime/platform/json.cc (right):

https://codereview.chromium.org/12035086/diff/2003/runtime/platform/json.cc#n...
runtime/platform/json.cc:237: ASSERT(!"illegal character in JSON string value");
Assert when checking caller data? Seems an exception is better here.

[hausner, 2013-01-24 23:35:15]

I didn't want to use a potentially big library in our code just to parse a very
simple format like JSON. Also, I wanted a parser that does not allocate any
dynamic memory when fishing out values from the messages.

https://codereview.chromium.org/12035086/diff/2003/runtime/platform/json.cc
File runtime/platform/json.cc (right):

https://codereview.chromium.org/12035086/diff/2003/runtime/platform/json.cc#n...
runtime/platform/json.cc:237: ASSERT(!"illegal character in JSON string value");
On 2013/01/24 23:28:23, Tom Ball wrote:
> Assert when checking caller data? Seems an exception is better here.

We don't use exceptions in our C++ code. Asserting is fine, since the
debugger/json code is supposed to escape all strings. If we do find an
un-escaped value, it's an internal error.

[Tom Ball, 2013-01-24 23:52:28]

sgtm