Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 12035007: Issue 7999: DartEditor analyser goes into infinite loop, caused by class definition inside switch st (Closed)

Created:
7 years, 11 months ago by danrubel
Modified:
7 years, 11 months ago
Reviewers:
scheglov, kasperl
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : add test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -0 lines) Patch
M compiler/java/com/google/dart/compiler/parser/DartParser.java View 1 chunk +2 lines, -0 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/parser/SyntaxTest.java View 1 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
danrubel
7 years, 11 months ago (2013-01-21 13:30:50 UTC) #1
kasperl
Could this change include a regression test case?
7 years, 11 months ago (2013-01-21 13:50:17 UTC) #2
danrubel
On 2013/01/21 13:50:17, kasperl wrote: > Could this change include a regression test case? Done.
7 years, 11 months ago (2013-01-21 15:16:25 UTC) #3
scheglov
7 years, 11 months ago (2013-01-21 16:53:18 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698