Issue 12035004: Add support for having both 10.8 and 10.7 mac bots side by side on the buildbot waterfall

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12035004: Add support for having both 10.8 and 10.7 mac bots side by side on the buildbot waterfall (Closed)

Created:
7 years, 11 months ago by ricow1

Modified:
7 years, 11 months ago

Reviewers:
Lasse Reichstein Nielsen

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Add support for having both 10.8 and 10.7 mac bots side by side on the buildbot waterfall Committed: https://code.google.com/p/dart/source/detail?r=17335

Patch Set 1 #

Total comments: 2

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -2 lines)			Patch
	M	tools/bots/compiler.py	View		2 chunks	+5 lines, -2 lines	2 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein Nielsen

7 years, 11 months ago (2013-01-21 08:02:00 UTC) #2

lgtm

https://codereview.chromium.org/12035004/diff/1/tools/bots/compiler.py
File tools/bots/compiler.py (right):

https://codereview.chromium.org/12035004/diff/1/tools/bots/compiler.py#newcode25
tools/bots/compiler.py:25:
r'dart2js-(ie9|ie10|ff|safari|chrome|opera)-(win7|win8|mac10\.8|mac10\.7|linux)(-(all|html))?(-(\d+)-(\d+))?')
mac10\.[78]

https://codereview.chromium.org/12035004/diff/1/tools/bots/compiler.py#newcode83
tools/bots/compiler.py:83: if system == 'mac10.8' or system == 'mac10.7':
Is there a "startsWith" so you can just check if it starts with "mac"?

Expand Messages | Collapse Messages