pkg/http_server more virtual dir test cleanup

pkg/http_server more virtual dir test cleanup

Preparing for https://code.google.com/p/dart/issues/detail?id=15893 fix

R=ajohnsen@google.com

Committed: https://code.google.com/p/dart/source/detail?r=31567

[Anders Johnsen, 2014-01-07 07:42:10]

LGTM

https://codereview.chromium.org/120343005/diff/90001/pkg/http_server/test/uti...
File pkg/http_server/test/utils.dart (right):

https://codereview.chromium.org/120343005/diff/90001/pkg/http_server/test/uti...
pkg/http_server/test/utils.dart:26: String path,
Indentation

https://codereview.chromium.org/120343005/diff/90001/pkg/http_server/test/uti...
pkg/http_server/test/utils.dart:68: Future<HttpHeaders>
getHeaders(VirtualDirectory virDir, String path) =>
Please use { ... } for multiline body.

https://codereview.chromium.org/120343005/diff/90001/pkg/http_server/test/uti...
pkg/http_server/test/utils.dart:88: Future _withServer(Future func(HttpServer
server)) {
Consider:

{
  return HttpServer.bind('localhost', 0)
      .then((server) {
        return func(server).whenComplete(server.close);
      });
}

[kevmoo, 2014-01-07 19:36:52]

https://codereview.chromium.org/120343005/diff/90001/pkg/http_server/test/uti...
File pkg/http_server/test/utils.dart (right):

https://codereview.chromium.org/120343005/diff/90001/pkg/http_server/test/uti...
pkg/http_server/test/utils.dart:26: String path,
On 2014/01/07 07:42:10, Anders Johnsen wrote:
> Indentation

Done.

https://codereview.chromium.org/120343005/diff/90001/pkg/http_server/test/uti...
pkg/http_server/test/utils.dart:68: Future<HttpHeaders>
getHeaders(VirtualDirectory virDir, String path) =>
On 2014/01/07 07:42:10, Anders Johnsen wrote:
> Please use { ... } for multiline body.

Done.

https://codereview.chromium.org/120343005/diff/90001/pkg/http_server/test/uti...
pkg/http_server/test/utils.dart:88: Future _withServer(Future func(HttpServer
server)) {
I'll argue against this.

If func throws an error (and not a Future with an error) then whenComplete will
not be called.

I will modify the call to whenComplete to be a bit tighter, though

[kevmoo, 2014-01-07 19:37:33]

Committed patchset #4 manually as r31567 (presubmit successful).