Limit textual representation of arrays in debugger

Limit textual representation of arrays in debugger

The debugger wire protocol choked when large arrays were present, because it tried to send the entire array as textual value. This change limits the size of the textual representation to about 256 characters. If elements are dropped, they are printed as …

 
Committed: https://code.google.com/p/dart/source/detail?r=17486

[srdjan, 2013-01-23 18:35:45]

Friendly LGTM.

If you agree with comments, you can do it in a different CL, since the current
solution fixes an existing problem already.

https://codereview.chromium.org/12033039/diff/1/runtime/bin/dbg_message.cc
File runtime/bin/dbg_message.cc (right):

https://codereview.chromium.org/12033039/diff/1/runtime/bin/dbg_message.cc#ne...
runtime/bin/dbg_message.cc:157: static void
FormatTextualListValue(dart::TextBuffer* buf, Dart_Handle list) {
Do you want to do the same for very long Strings and Maps as well?

https://codereview.chromium.org/12033039/diff/1/runtime/bin/dbg_message.cc#ne...
runtime/bin/dbg_message.cc:170: Dart_Handle elem = Dart_ListGetAt(list, i);
Instead of adding and checking if buffer exceeded, you could compute the length
first and then add the element on condition that it does not exceed the max
length, otherwise you still could end up with a huge buffer.

[hausner, 2013-01-23 18:42:00]

Thank you. I do agree with your suggestions, will implement it in a follow-on
CL.