Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 1202943002: Begin transition to ProcessedSample in Profiler (Closed)

Created:
5 years, 6 months ago by Cutch
Modified:
5 years, 6 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Begin transition to ProcessedSample in Profiler - Introduce ProcessedSample and ProcessedSampleBuffer - Visit SampleBuffer *once* and build ProcessedSampleBuffer - Stop altering the SampleBuffer when processing samples - Beginning of support for chained samples - Use ProcessedSampleBuffer instead of SampleBuffer for all passes in the ProfilerService. More cleanups here will follow. R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/7f7fcf03ee1c86948dbc1766bf6cc0acb75608e8

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+429 lines, -232 lines) Patch
M runtime/vm/profiler.h View 1 5 chunks +130 lines, -14 lines 0 comments Download
M runtime/vm/profiler.cc View 1 4 chunks +213 lines, -107 lines 0 comments Download
M runtime/vm/profiler_service.cc View 1 38 chunks +86 lines, -111 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Cutch
5 years, 6 months ago (2015-06-23 22:03:11 UTC) #2
rmacnak
lgtm https://codereview.chromium.org/1202943002/diff/1/runtime/vm/profiler.h File runtime/vm/profiler.h (right): https://codereview.chromium.org/1202943002/diff/1/runtime/vm/profiler.h#newcode465 runtime/vm/profiler.h:465: intptr_t cid() const { return cid_; } Consider ...
5 years, 6 months ago (2015-06-23 22:38:55 UTC) #3
Cutch
https://codereview.chromium.org/1202943002/diff/1/runtime/vm/profiler.h File runtime/vm/profiler.h (right): https://codereview.chromium.org/1202943002/diff/1/runtime/vm/profiler.h#newcode465 runtime/vm/profiler.h:465: intptr_t cid() const { return cid_; } On 2015/06/23 ...
5 years, 6 months ago (2015-06-24 13:54:35 UTC) #4
Cutch
5 years, 6 months ago (2015-06-24 13:54:44 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
7f7fcf03ee1c86948dbc1766bf6cc0acb75608e8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698