Hide private corelib's method from stack trace in exceptions.

Hide private corelib's method from stack trace in exceptions.
Committed: https://code.google.com/p/dart/source/detail?r=17489

[siva, 2013-01-19 01:12:13]

LGTM

I am a little confused that we want to see public functions of private classes
but what to hide private functions of public classes.

(We may later want to have a more efficient way of figuring out if a function is
private or not if this is going to be used a lot in other places as well).

https://codereview.chromium.org/12025038/diff/3001/runtime/vm/exceptions.cc
File runtime/vm/exceptions.cc (right):

https://codereview.chromium.org/12025038/diff/3001/runtime/vm/exceptions.cc#n...
runtime/vm/exceptions.cc:24: "Includes also core-lib's private methods");
Should this be limited to just the core lib or all the other libraries too (e.g
dart:isolate, dart:io, dart:scalaralists etc.).

https://codereview.chromium.org/12025038/diff/3001/runtime/vm/exceptions.cc#n...
runtime/vm/exceptions.cc:38: }
We should probably pull this code into a helper method in
class Function { ...} so that here we can just do
return func.IsPrivate() ? false : true;

[srdjan, 2013-01-22 22:17:29]

Redesigned CL as discussed. Mark certain functions as invisible in stack trace.
Please have another look. Added a couple of function that I noticed, but more
can be added later.


On 2013/01/19 01:12:13, siva wrote:
> LGTM
> 
> I am a little confused that we want to see public functions of private classes
> but what to hide private functions of public classes.
> 
> (We may later want to have a more efficient way of figuring out if a function
is
> private or not if this is going to be used a lot in other places as well).
> 
> https://codereview.chromium.org/12025038/diff/3001/runtime/vm/exceptions.cc
> File runtime/vm/exceptions.cc (right):
> 
>
https://codereview.chromium.org/12025038/diff/3001/runtime/vm/exceptions.cc#n...
> runtime/vm/exceptions.cc:24: "Includes also core-lib's private methods");
> Should this be limited to just the core lib or all the other libraries too
(e.g
> dart:isolate, dart:io, dart:scalaralists etc.).
> 
>
https://codereview.chromium.org/12025038/diff/3001/runtime/vm/exceptions.cc#n...
> runtime/vm/exceptions.cc:38: }
> We should probably pull this code into a helper method in
> class Function { ...} so that here we can just do
> return func.IsPrivate() ? false : true;

[Ivan Posva, 2013-01-23 01:17:26]

LGTM with comment.

-Ivan

https://codereview.chromium.org/12025038/diff/14001/runtime/vm/exceptions.cc
File runtime/vm/exceptions.cc (right):

https://codereview.chromium.org/12025038/diff/14001/runtime/vm/exceptions.cc#...
runtime/vm/exceptions.cc:24: "Includes also core-lib's private methods");
private -> invisible

https://codereview.chromium.org/12025038/diff/14001/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/12025038/diff/14001/runtime/vm/object.cc#newc...
runtime/vm/object.cc:135: static void CallIt(const Library& lib,
Please CallIt something more descriptive.

[siva, 2013-01-23 01:40:22]

lgtm

https://codereview.chromium.org/12025038/diff/14001/runtime/vm/exceptions.cc
File runtime/vm/exceptions.cc (right):

https://codereview.chromium.org/12025038/diff/14001/runtime/vm/exceptions.cc#...
runtime/vm/exceptions.cc:24: "Includes also core-lib's private methods");
Since we plan on allowing some non core-lib methods to also be invisible we
should probably drop core-lib, maybe say
something generic
"Stack traces will include methods marked invisible"

[srdjan, 2013-01-23 19:22:29]

https://codereview.chromium.org/12025038/diff/14001/runtime/vm/exceptions.cc
File runtime/vm/exceptions.cc (right):

https://codereview.chromium.org/12025038/diff/14001/runtime/vm/exceptions.cc#...
runtime/vm/exceptions.cc:24: "Includes also core-lib's private methods");
On 2013/01/23 01:17:26, Ivan Posva wrote:
> private -> invisible

Done.

https://codereview.chromium.org/12025038/diff/14001/runtime/vm/exceptions.cc#...
runtime/vm/exceptions.cc:24: "Includes also core-lib's private methods");
On 2013/01/23 01:40:22, siva wrote:
> Since we plan on allowing some non core-lib methods to also be invisible we
> should probably drop core-lib, maybe say
> something generic
> "Stack traces will include methods marked invisible"

Done.

https://codereview.chromium.org/12025038/diff/14001/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/12025038/diff/14001/runtime/vm/object.cc#newc...
runtime/vm/object.cc:135: static void CallIt(const Library& lib,
On 2013/01/23 01:17:26, Ivan Posva wrote:
> Please CallIt something more descriptive.

MarkFunctionAsInvisible