Issue 12021022: Stop supporting map literals with 1 type argument

Issue 12021022: Stop supporting map literals with 1 type argument (Closed)

Created:
7 years, 11 months ago by hausner

Modified:
7 years, 11 months ago

Reviewers:
regis

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Stop supporting map literals with 1 type argument To be checked in next week Tue (Jan 22) Committed: https://code.google.com/p/dart/source/detail?r=17410

Patch Set 2 : #

Total comments: 2

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -37 lines)			Patch
M	pkg/http/lib/src/base_request.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/http/lib/src/base_response.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/http/lib/src/io_client.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/http/lib/src/multipart_request.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/http/lib/src/response.dart	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/http/lib/src/streamed_response.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/http/lib/src/utils.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/http/test/utils.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/oauth2/lib/src/utils.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/parser.cc	View		2 chunks	+7 lines, -22 lines	2 comments	Download
M	sdk/lib/_internal/compiler/implementation/dart_backend/renamer.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/libraries.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/co19/co19-dart2dart.status	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/co19/co19-runtime.status	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	utils/pub/curl_client.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	utils/pub/utils.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	utils/tests/pub/curl_client_test.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

regis

I do not understand this change. The equivalent of the legacy <String>{} should be <String, ...

7 years, 11 months ago (2013-01-18 22:29:42 UTC) #2

regis

LGTM with one detail. https://codereview.chromium.org/12021022/diff/5001/runtime/vm/parser.cc File runtime/vm/parser.cc (right): https://codereview.chromium.org/12021022/diff/5001/runtime/vm/parser.cc#newcode8631 runtime/vm/parser.cc:8631: AbstractType& value_type = Type::ZoneHandle(Type::DynamicType()); You ...

7 years, 11 months ago (2013-01-18 23:43:59 UTC) #4

hausner

7 years, 11 months ago (2013-01-19 00:02:12 UTC) #5

Thanks for the review. Will check this in next week Tuesday as announced in the
BREAKING CHANGE email.

https://codereview.chromium.org/12021022/diff/5001/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/12021022/diff/5001/runtime/vm/parser.cc#newco...
runtime/vm/parser.cc:8631: AbstractType& value_type =
Type::ZoneHandle(Type::DynamicType());
On 2013/01/18 23:43:59, regis wrote:
> You can now move this line down. Same as key_type.
value_type is used below, in 8698. Leaving as is, as discussed offline.

Expand Messages | Collapse Messages