Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 12018014: Start allowing mixin application extensions. (Closed)

Created:
7 years, 11 months ago by kasperl
Modified:
7 years, 11 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Start allowing mixin application extensions. This CL builds upon the code in https://codereview.chromium.org/11886097/ which needs to land before this one. R=ahe@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=17270

Patch Set 1 #

Patch Set 2 : Extend test cases. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -31 lines) Patch
M sdk/lib/_internal/compiler/implementation/elements/modelx.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/resolution/members.dart View 4 chunks +22 lines, -14 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/scanner/listener.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/scanner/parser.dart View 1 chunk +6 lines, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/tree/nodes.dart View 1 chunk +1 line, -1 line 0 comments Download
A + tests/language/mixin_extends_field_test.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download
A + tests/language/mixin_extends_is_test.dart View 1 1 chunk +6 lines, -6 lines 0 comments Download
A + tests/language/mixin_extends_method_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/language/mixin_naming_test.dart View 1 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
kasperl
7 years, 11 months ago (2013-01-18 11:42:17 UTC) #1
ahe
7 years, 11 months ago (2013-01-18 12:46:54 UTC) #2
LGTM

I don't think you're testing that a typedef-mixin-application can use a
class-mixin-application as supertype and vice versa.

Powered by Google App Engine
This is Rietveld 408576698