Some more ^= to |=

Some more ^= to |= 
Committed: https://code.google.com/p/dart/source/detail?r=17310

[hausner, 2013-01-18 19:04:48]

LGTM but see comment about pattern

HandleType& h = HandleType::Handle();
h |= value.raw();

Why not do this directly:
HandleType& h = HandleType::Handle(value.raw());

Also, how much does this optimization buy us in places that are not loops? Can
you actually measure a runtime difference with this change?

https://codereview.chromium.org/12017020/diff/1/runtime/lib/byte_array.cc
File runtime/lib/byte_array.cc (right):

https://codereview.chromium.org/12017020/diff/1/runtime/lib/byte_array.cc#new...
runtime/lib/byte_array.cc:122: bigint |= integer.raw();                         
                         \
Why not Bigint& bigint = Bigint::Handle(integer.raw());

https://codereview.chromium.org/12017020/diff/1/runtime/lib/integers.cc
File runtime/lib/integers.cc (right):

https://codereview.chromium.org/12017020/diff/1/runtime/lib/integers.cc#newco...
runtime/lib/integers.cc:25: Bigint& bigint = Bigint::Handle();
Why not Bigint& bigint = Bigint::Handle(i.raw);

https://codereview.chromium.org/12017020/diff/1/runtime/lib/integers.cc#newco...
runtime/lib/integers.cc:32: mint |= i.raw();
ditto

https://codereview.chromium.org/12017020/diff/1/runtime/lib/integers.cc#newco...
runtime/lib/integers.cc:220: Smi& smi_value = Smi::Handle();
ditto

https://codereview.chromium.org/12017020/diff/1/runtime/lib/isolate.cc
File runtime/lib/isolate.cc (right):

https://codereview.chromium.org/12017020/diff/1/runtime/lib/isolate.cc#newcode48
runtime/lib/isolate.cc:48: error |= obj.raw();
ditto

[srdjan, 2013-01-18 20:02:47]

I have not been able to measure performance improvements. However, we know this
is faster way to do it.

https://codereview.chromium.org/12017020/diff/1/runtime/lib/byte_array.cc
File runtime/lib/byte_array.cc (right):

https://codereview.chromium.org/12017020/diff/1/runtime/lib/byte_array.cc#new...
runtime/lib/byte_array.cc:122: bigint |= integer.raw();                         
                         \
On 2013/01/18 19:04:48, hausner wrote:
> Why not Bigint& bigint = Bigint::Handle(integer.raw());

Because 'integer.raw' is not of static type RawBigint* but RawInteger*

https://codereview.chromium.org/12017020/diff/1/runtime/lib/integers.cc
File runtime/lib/integers.cc (right):

https://codereview.chromium.org/12017020/diff/1/runtime/lib/integers.cc#newco...
runtime/lib/integers.cc:25: Bigint& bigint = Bigint::Handle();
On 2013/01/18 19:04:48, hausner wrote:
> Why not Bigint& bigint = Bigint::Handle(i.raw);

Ditto.

https://codereview.chromium.org/12017020/diff/1/runtime/lib/integers.cc#newco...
runtime/lib/integers.cc:32: mint |= i.raw();
On 2013/01/18 19:04:48, hausner wrote:
> ditto

Ditto.

https://codereview.chromium.org/12017020/diff/1/runtime/lib/isolate.cc
File runtime/lib/isolate.cc (right):

https://codereview.chromium.org/12017020/diff/1/runtime/lib/isolate.cc#newcode48
runtime/lib/isolate.cc:48: error |= obj.raw();
On 2013/01/18 19:04:48, hausner wrote:
> ditto

ditto.

https://codereview.chromium.org/12017020/diff/1/runtime/lib/isolate.cc#newcod...
runtime/lib/isolate.cc:189: error_obj |= obj.raw();
This was wrong, fixed it.

https://codereview.chromium.org/12017020/diff/1/runtime/lib/isolate.cc#newcod...
runtime/lib/isolate.cc:335: errobj |= result.raw();
Was wrong, fixed it.