Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 120163006: Fix HttpResponse::writeCharCode. (Closed)

Created:
6 years, 11 months ago by Anders Johnsen
Modified:
6 years, 11 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix HttpResponse::writeCharCode. We now always ensure the encoding when writing to the IOSink. BUG=https://code.google.com/p/dart/issues/detail?id=15905 R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=31531

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M sdk/lib/io/http_impl.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M tests/standalone/io/http_server_response_test.dart View 2 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Anders Johnsen
6 years, 11 months ago (2014-01-07 07:36:32 UTC) #1
Søren Gjesse
lgtm
6 years, 11 months ago (2014-01-07 07:41:13 UTC) #2
Anders Johnsen
6 years, 11 months ago (2014-01-07 07:42:36 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r31531 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698