Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 1201523002: Library prefix is a primary expression in the newest spec (Closed)

Created:
5 years, 6 months ago by hausner
Modified:
5 years, 6 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org, gbracha
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Library prefixes used to be invisible. The newest spec treats them as objects, but it's a compile-time error to do most anything with them. This change brings the VM in compliance with the current spec. BUG=23612 R=iposva@google.com Committed: https://github.com/dart-lang/sdk/commit/84be183a329c971541ba882a2244921c16c8f990

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -20 lines) Patch
M runtime/vm/parser.cc View 2 chunks +8 lines, -3 lines 0 comments Download
M tests/language/language.status View 1 chunk +0 lines, -17 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
hausner
5 years, 6 months ago (2015-06-20 00:05:03 UTC) #2
Ivan Posva
LGTM -ip
5 years, 6 months ago (2015-06-22 19:18:03 UTC) #3
hausner
5 years, 6 months ago (2015-06-22 20:02:09 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
84be183a329c971541ba882a2244921c16c8f990 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698