Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1034)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1201383002: Port irregexp bytecode compiler and interpreter from V8 r24065. (Closed)

Created:
5 years, 6 months ago by rmacnak
Modified:
5 years, 5 months ago
Reviewers:
zerny-google, srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org, Ivan Posva
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Port irregexp bytecode compiler and interpreter from V8 r24065. R=srdjan@google.com Committed: https://github.com/dart-lang/sdk/commit/d1475c03567d1d59e76026fed519b41eac51eee0

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 9

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1842 lines, -2612 lines) Patch
M runtime/lib/regexp.cc View 1 2 chunks +11 lines, -3 lines 0 comments Download
M runtime/vm/compiler.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M runtime/vm/intermediate_language.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/intrinsifier_arm.cc View 1 2 3 4 2 chunks +4 lines, -0 lines 0 comments Download
M runtime/vm/intrinsifier_arm64.cc View 1 2 3 4 2 chunks +4 lines, -0 lines 0 comments Download
M runtime/vm/intrinsifier_ia32.cc View 1 2 3 4 2 chunks +4 lines, -0 lines 0 comments Download
M runtime/vm/intrinsifier_mips.cc View 1 2 3 4 2 chunks +4 lines, -0 lines 0 comments Download
M runtime/vm/intrinsifier_x64.cc View 1 2 3 4 2 chunks +4 lines, -0 lines 0 comments Download
M runtime/vm/object.h View 1 2 3 4 3 chunks +11 lines, -0 lines 0 comments Download
M runtime/vm/object.cc View 1 2 3 4 2 chunks +10 lines, -0 lines 0 comments Download
M runtime/vm/raw_object.h View 1 2 3 4 1 chunk +5 lines, -1 line 0 comments Download
M runtime/vm/raw_object_snapshot.cc View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M runtime/vm/regexp.h View 1 2 2 chunks +27 lines, -4 lines 0 comments Download
M runtime/vm/regexp.cc View 1 2 3 4 12 chunks +170 lines, -22 lines 0 comments Download
M runtime/vm/regexp_assembler.h View 1 2 3 4 4 chunks +39 lines, -441 lines 0 comments Download
M runtime/vm/regexp_assembler.cc View 2 chunks +0 lines, -1914 lines 0 comments Download
A runtime/vm/regexp_assembler_bytecode.h View 1 2 3 4 1 chunk +144 lines, -0 lines 0 comments Download
A runtime/vm/regexp_assembler_bytecode.cc View 1 2 3 4 1 chunk +594 lines, -0 lines 0 comments Download
A runtime/vm/regexp_assembler_bytecode_inl.h View 1 2 3 4 1 chunk +57 lines, -0 lines 0 comments Download
A + runtime/vm/regexp_assembler_ir.h View 2 chunks +4 lines, -210 lines 0 comments Download
A + runtime/vm/regexp_assembler_ir.cc View 2 chunks +1 line, -13 lines 0 comments Download
A runtime/vm/regexp_bytecodes.h View 1 2 3 4 1 chunk +79 lines, -0 lines 0 comments Download
A runtime/vm/regexp_interpreter.h View 1 2 3 4 1 chunk +33 lines, -0 lines 0 comments Download
A runtime/vm/regexp_interpreter.cc View 1 2 3 4 1 chunk +621 lines, -0 lines 0 comments Download
M runtime/vm/regexp_test.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/vm_sources.gypi View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
rmacnak
corelib/regexp/stack-overflow_test throws StackOverflow with the bytecode version, but does not throw on the flow graph ...
5 years, 6 months ago (2015-06-25 00:14:47 UTC) #2
srdjan
lgtm https://codereview.chromium.org/1201383002/diff/60001/runtime/vm/object.cc File runtime/vm/object.cc (right): https://codereview.chromium.org/1201383002/diff/60001/runtime/vm/object.cc#newcode20755 runtime/vm/object.cc:20755: } If you set one, do you want ...
5 years, 5 months ago (2015-07-07 19:30:26 UTC) #3
rmacnak
https://codereview.chromium.org/1201383002/diff/60001/runtime/vm/object.cc File runtime/vm/object.cc (right): https://codereview.chromium.org/1201383002/diff/60001/runtime/vm/object.cc#newcode20755 runtime/vm/object.cc:20755: } On 2015/07/07 19:30:25, srdjan wrote: > If you ...
5 years, 5 months ago (2015-07-07 21:42:54 UTC) #4
rmacnak
5 years, 5 months ago (2015-07-07 21:43:38 UTC) #5
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) manually as
d1475c03567d1d59e76026fed519b41eac51eee0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698