Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 1201263002: performance measurement: add explicit temp source directory argument (Closed)

Created:
5 years, 6 months ago by danrubel
Modified:
5 years, 6 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

performance measurement: add explicit temp source directory argument BUG= R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/1ce49788eab0f9b448251ca7f092ab27f76e7028

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -41 lines) Patch
M pkg/analysis_server/test/performance/input_converter.dart View 9 chunks +50 lines, -29 lines 0 comments Download
M pkg/analysis_server/test/performance/instrumentation_input_converter.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/performance/local_runner.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/analysis_server/test/performance/log_file_input_converter.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/test/performance/main.dart View 7 chunks +19 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
danrubel
5 years, 6 months ago (2015-06-23 19:19:16 UTC) #2
scheglov
LGTM
5 years, 6 months ago (2015-06-23 19:20:25 UTC) #3
danrubel
5 years, 6 months ago (2015-06-23 19:53:05 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
1ce49788eab0f9b448251ca7f092ab27f76e7028 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698