dart2cps: Fix bug in constructors.

dart2cps: Fix bug in constructors.

When visiting another constructor, the visitor must use another tree elements mapping (and source file info).

BUG=
R=floitsch@google.com

Committed: https://github.com/dart-lang/sdk/commit/4a1e6c7966272729d6350f9759f1645d4278983e

Reverted: https://github.com/dart-lang/sdk/commit/382319fe701021ecfa1e9faa37ef3ac589876007

Committed: https://github.com/dart-lang/sdk/commit/56158b54a1032106728a6c872e4e4ee6877faa38

[asgerf, 2015-06-22 10:28:09]

asgerf@google.com changed reviewers:
+ floitsch@google.com

[floitsch, 2015-06-22 11:46:53]

LGTM if you can move it to evaluateConstructorFieldInitializers.

https://codereview.chromium.org/1200823002/diff/1/pkg/compiler/lib/src/cps_ir...
File pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart (right):

https://codereview.chromium.org/1200823002/diff/1/pkg/compiler/lib/src/cps_ir...
pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart:2584: constructor =
constructor.implementation;
I think we should always have implementations in the cps_ir_builder task.
From what I can see the constructor comes from a constructor-list, which in turn
is filled in evaluateConstructorFieldInitializers.
We should just get the implementation there.
(In my checkout this would be line 2437).

[asgerf, 2015-06-22 13:38:08]

PTAL.

I went digging a bit and found more serious issues.

I will update the CL description before commit.

[floitsch, 2015-06-22 14:04:57]

LGTM.

[asgerf, 2015-06-22 15:53:52]

Committed patchset #3 (id:40001) manually as
4a1e6c7966272729d6350f9759f1645d4278983e (presubmit successful).

[asgerf, 2015-06-23 08:55:07]

Committed patchset #4 (id:60001) manually as
56158b54a1032106728a6c872e4e4ee6877faa38 (presubmit successful).

[asgerf, 2015-06-23 08:56:05]

On 2015/06/23 08:55:07, asgerf wrote:
> Committed patchset #4 (id:60001) manually as
> 56158b54a1032106728a6c872e4e4ee6877faa38 (presubmit successful).

It seems this commit was actually fine. It just ran together with a broken one
and I defensively reverted because I was leaving work.