Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1025)

Issue 1200403003: JSInvocationMirror - return unmodifiable list or map (Closed)

Created:
5 years, 5 months ago by sra1
Modified:
5 years, 5 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : .status changes #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -22 lines) Patch
M sdk/lib/_internal/compiler/js_lib/constant_map.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/js_lib/js_helper.dart View 2 chunks +4 lines, -11 lines 0 comments Download
M tests/co19/co19-co19.status View 1 1 chunk +0 lines, -1 line 0 comments Download
M tests/co19/co19-dart2js.status View 1 9 chunks +0 lines, -9 lines 0 comments Download
M tests/co19/co19-runtime.status View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
sra1
This is mainly to reduce the number of places that assign to .fixed$length
5 years, 5 months ago (2015-06-24 02:14:42 UTC) #2
floitsch
LGTM.
5 years, 5 months ago (2015-06-24 12:20:09 UTC) #3
sra1
Committed patchset #1 (id:1) manually as ec9ecdd3ff4d6b595cb567ae120757dbb591f88d (presubmit successful).
5 years, 5 months ago (2015-06-24 14:47:06 UTC) #4
sra1
5 years, 5 months ago (2015-06-24 18:00:47 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
9425621eacb98695525b554f50cf46a8e7f3b45a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698