Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 1199473003: Add storage of class id and state bit to the profiler's Sample (Closed)

Created:
5 years, 6 months ago by Cutch
Modified:
5 years, 6 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add storage of class id and state bit to the profiler's Sample - Stop storing sp and fp in Sample. Both are not used after the stack walk - Add AllocationSample bit to Sample's state_ - Add a metadata_ field to Sample - Use metadata_ to store a class id when AllocationSample bit is set R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/50842cd27ad31b6a378ffe40f3c8ba961bbbbec2

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -33 lines) Patch
M runtime/vm/profiler.h View 1 6 chunks +22 lines, -20 lines 0 comments Download
M runtime/vm/profiler.cc View 6 chunks +13 lines, -11 lines 0 comments Download
M runtime/vm/profiler_test.cc View 3 chunks +14 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Cutch
5 years, 6 months ago (2015-06-22 22:05:14 UTC) #2
rmacnak
lgtm https://codereview.chromium.org/1199473003/diff/1/runtime/vm/profiler.h File runtime/vm/profiler.h (right): https://codereview.chromium.org/1199473003/diff/1/runtime/vm/profiler.h#newcode162 runtime/vm/profiler.h:162: lr_ = 0; metadata = 0
5 years, 6 months ago (2015-06-22 22:23:19 UTC) #3
Cutch
https://codereview.chromium.org/1199473003/diff/1/runtime/vm/profiler.h File runtime/vm/profiler.h (right): https://codereview.chromium.org/1199473003/diff/1/runtime/vm/profiler.h#newcode162 runtime/vm/profiler.h:162: lr_ = 0; On 2015/06/22 22:23:19, rmacnak wrote: > ...
5 years, 6 months ago (2015-06-23 13:47:13 UTC) #4
Cutch
5 years, 6 months ago (2015-06-23 13:47:44 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
50842cd27ad31b6a378ffe40f3c8ba961bbbbec2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698