Issue 1199343006: Don't use ES6 map if browser has no Map - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(199)

My Issues | Starred Open | Closed | All

Issue 1199343006: Don't use ES6 map if browser has no Map (Closed)

Created:
5 years, 6 months ago by Harry Terkelsen

Modified:
5 years, 6 months ago

Reviewers:
Siggi Cherem (dart-lang), sra1, floitsch

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Don't use ES6 map if browser has no Map BUG= R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/a684edf08b049786b54c91f176af75655d1ee95d

Patch Set 1 #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	sdk/lib/_internal/compiler/js_lib/collection_patch.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Harry Terkelsen

I made a big blunder on the ES6 map change. It is using the ES6 ...

5 years, 6 months ago (2015-06-24 23:49:19 UTC) #2

Harry Terkelsen

Committed patchset #1 (id:1) manually as a684edf08b049786b54c91f176af75655d1ee95d (presubmit successful).

5 years, 6 months ago (2015-06-24 23:51:23 UTC) #4

Message was sent while issue was closed.

LGTM.
Who was reviewing this??? ;)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Powered by Google App Engine

This is Rietveld 408576698