Issue 119933002: Fix bug in bound_closure_test.

Issue 119933002: Fix bug in bound_closure_test. (Closed)

Created:
7 years ago by ahe

Modified:
7 years ago

Reviewers:
floitsch

CC:
reviews_dartlang.org, sra1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix bug in bound_closure_test. R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=31335

Patch Set 2 : Address comments and fix other unbound names. #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -5 lines)			Patch
A	dart/tests/compiler/dart2js_native/bound_closure_super_test.dart	View	1	1 chunk	+25 lines, -0 lines	0 comments	Download
M	dart/tests/compiler/dart2js_native/bound_closure_test.dart	View		3 chunks	+1 line, -5 lines	0 comments	Download
M	dart/tests/compiler/dart2js_native/dart2js_native.status	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

floitsch

LGTM. https://codereview.chromium.org/119933002/diff/1/dart/tests/compiler/dart2js_native/bound_closure_super_test.dart File dart/tests/compiler/dart2js_native/bound_closure_super_test.dart (right): https://codereview.chromium.org/119933002/diff/1/dart/tests/compiler/dart2js_native/bound_closure_super_test.dart#newcode11 dart/tests/compiler/dart2js_native/bound_closure_super_test.dart:11: bound_closure_test.main(); Explain that the origin main is doing ...

7 years ago (2013-12-20 13:17:36 UTC) #2

ahe

Thank you, Florian! https://codereview.chromium.org/119933002/diff/1/dart/tests/compiler/dart2js_native/bound_closure_super_test.dart File dart/tests/compiler/dart2js_native/bound_closure_super_test.dart (right): https://codereview.chromium.org/119933002/diff/1/dart/tests/compiler/dart2js_native/bound_closure_super_test.dart#newcode11 dart/tests/compiler/dart2js_native/bound_closure_super_test.dart:11: bound_closure_test.main(); On 2013/12/20 13:17:37, floitsch wrote: ...

7 years ago (2013-12-20 13:26:37 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r31335 (presubmit successful).

Expand Messages | Collapse Messages