Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1199283002: Fix bot failure: use platform specific separator (Closed)

Created:
5 years, 6 months ago by srdjan
Modified:
5 years, 6 months ago
Reviewers:
siva
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix bot failure: use platform specific separator BUG= R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/f3c0a280d2884718595cfd7c040a21baad4ff548

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M tests/standalone/io/file_write_only_test.dart View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
srdjan
5 years, 6 months ago (2015-06-23 20:29:16 UTC) #2
siva
lgtm
5 years, 6 months ago (2015-06-23 20:30:09 UTC) #3
srdjan
Committed patchset #1 (id:1) manually as f3c0a280d2884718595cfd7c040a21baad4ff548 (presubmit successful).
5 years, 6 months ago (2015-06-23 20:30:25 UTC) #4
Søren Gjesse
5 years, 6 months ago (2015-06-24 08:44:28 UTC) #5
Message was sent while issue was closed. 
On 2015/06/23 20:30:25, srdjan wrote:
> Committed patchset #1 (id:1) manually as
> f3c0a280d2884718595cfd7c040a21baad4ff548 (presubmit successful).

Thanks for looking into this, but I assume this did not fix any failures. On
Windows you can combine / and \ - we have a lot of tests that uses / on all
platforms. I think I fixed it with https://codereview.chromium.org/1202893004/,
sorry about that.

Powered by Google App Engine
This is Rietveld 408576698