Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issue 1198993003: - Split big integer tests into pieces. (Closed)

Created:
5 years, 6 months ago by Ivan Posva
Modified:
5 years, 6 months ago
Reviewers:
regis, srdjan
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : updated to ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -21 lines) Patch
M tests/corelib/big_integer_arith_vm_test.dart View 2 chunks +23 lines, -20 lines 0 comments Download
M tests/corelib/corelib.status View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Ivan Posva
5 years, 6 months ago (2015-06-22 19:16:05 UTC) #2
srdjan
lgtm
5 years, 6 months ago (2015-06-22 19:18:50 UTC) #3
Ivan Posva
Committed patchset #2 (id:20001) manually as d9da805f07feb8b613832a5820c875f5b8703141 (presubmit successful).
5 years, 6 months ago (2015-06-22 19:22:22 UTC) #4
regis
5 years, 6 months ago (2015-06-22 19:36:15 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698