Issue 11983005: Move list helper-classes from core to collection-dev.

Issue 11983005: Move list helper-classes from core to collection-dev. (Closed)

Created:
7 years, 11 months ago by floitsch

Modified:
7 years, 11 months ago

Reviewers:
Lasse Reichstein Nielsen

CC:
reviews_dartlang.org, Anders Johnsen

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Move list helper-classes from core to collection-dev. Committed: https://code.google.com/p/dart/source/detail?r=17293

Patch Set 2 : Address comments and fix bad merge. #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -456 lines)			Patch
M	sdk/lib/collection_dev/collection_dev.dart	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	sdk/lib/collection_dev/collection_dev_sources.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download
A +	sdk/lib/collection_dev/list.dart	View	1	3 chunks	+4 lines, -192 lines	0 comments	Download
M	sdk/lib/core/list.dart	View	1	1 chunk	+0 lines, -263 lines	0 comments	Download
M	sdk/lib/html/dart2js/html_dart2js.dart	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/dom/templates/html/dart2js/html_dart2js.darttemplate	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/dom/templates/html/dartium/html_dartium.darttemplate	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

floitsch

https://codereview.chromium.org/11983005/diff/1/sdk/lib/collection_dev/list.dart File sdk/lib/collection_dev/list.dart (right): https://codereview.chromium.org/11983005/diff/1/sdk/lib/collection_dev/list.dart#newcode8 sdk/lib/collection_dev/list.dart:8: * Skeleton class for an unmodifiable [List]. Changed this ...

7 years, 11 months ago (2013-01-17 18:31:47 UTC) #1

Lasse Reichstein Nielsen

lgtm https://codereview.chromium.org/11983005/diff/1/sdk/lib/collection_dev/list.dart File sdk/lib/collection_dev/list.dart (right): https://codereview.chromium.org/11983005/diff/1/sdk/lib/collection_dev/list.dart#newcode157 sdk/lib/collection_dev/list.dart:157: * Iterates over a [Sequence] in growing index ...

7 years, 11 months ago (2013-01-18 11:34:25 UTC) #2

floitsch

7 years, 11 months ago (2013-01-18 17:02:29 UTC) #3

https://codereview.chromium.org/11983005/diff/1/sdk/lib/collection_dev/list.dart
File sdk/lib/collection_dev/list.dart (right):

https://codereview.chromium.org/11983005/diff/1/sdk/lib/collection_dev/list.d...
sdk/lib/collection_dev/list.dart:157: * Iterates over a [Sequence] in growing
index order.
On 2013/01/18 11:34:25, Lasse Reichstein Nielsen wrote:
> Sequence -> List.

Done.

Expand Messages | Collapse Messages