Issue 1197673003: dart2js cps: Get typed selectors for compound operators.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1197673003: dart2js cps: Get typed selectors for compound operators. (Closed)

Created:
5 years, 6 months ago by asgerf

Modified:
5 years, 6 months ago

Reviewers:
Kevin Millikin (Google)

CC:
reviews_dartlang.org, Johnni Winther

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

dart2js cps: Get typed selectors for compound operators. This dramatically improves type inference. Previously, i++ would completely destroy all type information known for i. BUG= R=kmillikin@google.com Committed: https://github.com/dart-lang/sdk/commit/c5bb081ed67bb917a11a972712f182a579a104e4

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -17 lines)			Patch
M	pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart	View		10 chunks	+21 lines, -11 lines	0 comments	Download
M	tests/compiler/dart2js/js_backend_cps_ir_closures_test.dart	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	tests/compiler/dart2js/js_backend_cps_ir_interceptors_test.dart	View	1	1 chunk	+4 lines, -4 lines	0 comments	Download
M	tests/compiler/dart2js_extra/dart2js_extra.status	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

asgerf

5 years, 6 months ago (2015-06-23 15:04:27 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
c5bb081ed67bb917a11a972712f182a579a104e4 (presubmit successful).