Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 11975049: Allowing inlining of static getters and methods in a different library. Also report an error if a g… (Closed)

Created:
7 years, 11 months ago by ngeoffray
Modified:
7 years, 11 months ago
Reviewers:
kasperl
CC:
reviews_dartlang.org, sra1
Visibility:
Public.

Description

Allowing inlining of static getters and methods in a different library. Also report an error if a getter has parameters. Committed: https://code.google.com/p/dart/source/detail?r=17250

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -9 lines) Patch
M sdk/lib/_internal/compiler/implementation/resolution/members.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/builder.dart View 3 chunks +6 lines, -6 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/codegen.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tests/compiler/dart2js/mock_compiler.dart View 1 1 chunk +4 lines, -0 lines 0 comments Download
M tests/language/language_dart2js.status View 1 chunk +0 lines, -2 lines 0 comments Download
A tests/language/other_library.dart View 1 chunk +15 lines, -0 lines 0 comments Download
A tests/language/private4_test.dart View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ngeoffray
7 years, 11 months ago (2013-01-17 17:17:53 UTC) #1
kasperl
7 years, 11 months ago (2013-01-18 06:37:25 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698