Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Issue 11973012: Rev the version of apache ant in third_party to 1.8.4. This will fix an issue with (Closed)

Created:
7 years, 11 months ago by devoncarew
Modified:
7 years, 11 months ago
Reviewers:
ricow1, danrubel
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Rev the version of apache ant in third_party to 1.8.4. This will fix an issue with windows build failures not being reported correctly (older versions of ant didn't properly return process eit codes). It will also let us use some newer features of ant. Committed: https://code.google.com/p/dart/source/detail?r=17228

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -21 lines) Patch
M compiler/dart-compiler.gyp View 1 chunk +1 line, -1 line 0 comments Download
M compiler/dart_analyzer.xml View 2 chunks +4 lines, -2 lines 0 comments Download
M compiler/dartium.gyp View 1 chunk +1 line, -1 line 2 comments Download
M editor/build/build.py View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/features/com.google.dart.eclipse.feature_releng/build.properties View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/features/com.google.dart.tools.deploy.feature_releng/build.properties View 1 chunk +1 line, -1 line 0 comments Download
M third_party/apache_ant/README View 1 chunk +93 lines, -13 lines 0 comments Download
M tools/create_editor.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
devoncarew
The new files in third_party/apache_ant/1.8.4 are not in this CL but will be part of ...
7 years, 11 months ago (2013-01-16 19:02:20 UTC) #1
ricow1
Rubberstamp LGTM, thanks for letting me know. CC'ing Peter since there are gyp changes in ...
7 years, 11 months ago (2013-01-16 19:05:33 UTC) #2
devoncarew
https://codereview.chromium.org/11973012/diff/1/compiler/dartium.gyp File compiler/dartium.gyp (right): https://codereview.chromium.org/11973012/diff/1/compiler/dartium.gyp#newcode2 compiler/dartium.gyp:2: # for details. All rights reserved. Use of this ...
7 years, 11 months ago (2013-01-16 19:09:16 UTC) #3
danrubel
7 years, 11 months ago (2013-01-16 20:46:14 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698