Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11973006: Private libraries used. (Closed)

Created:
7 years, 11 months ago by Johnni Winther
Modified:
7 years, 11 months ago
Reviewers:
ahe, sra1, ngeoffray, kasperl
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Private libraries used. Committed: https://code.google.com/p/dart/source/detail?r=17634

Patch Set 1 #

Total comments: 10

Patch Set 2 : Rebased #

Patch Set 3 : Rebased #

Patch Set 4 : Updated cf. comments. #

Patch Set 5 : Rebased #

Patch Set 6 : Generated files updated. #

Patch Set 7 : Add missing uses to js_helper. #

Patch Set 8 : Rebased #

Patch Set 9 : Update copy_dart.py to handle show in one line. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -116 lines) Patch
M sdk/lib/_internal/compiler/implementation/compiler.dart View 1 2 3 4 5 6 7 4 chunks +37 lines, -97 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/lib/async_patch.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/lib/core_patch.dart View 1 2 3 4 1 chunk +9 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/lib/interceptors.dart View 1 2 3 4 1 chunk +19 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/lib/isolate_helper.dart View 1 2 3 4 5 6 7 8 1 chunk +5 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/lib/isolate_patch.dart View 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/lib/js_helper.dart View 1 2 3 4 5 6 1 chunk +9 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/lib/math_patch.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/lib/mirrors_patch.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart View 1 2 3 4 1 chunk +0 lines, -3 lines 0 comments Download
M sdk/lib/chrome/dart2js/chrome_dart2js.dart View 1 2 3 4 5 6 7 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 14 chunks +18 lines, -15 lines 0 comments Download
M sdk/lib/html/html_common/html_common_dart2js.dart View 1 2 3 4 5 6 7 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/svg/dart2js/svg_dart2js.dart View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/web_audio/dart2js/web_audio_dart2js.dart View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M tests/compiler/dart2js_native/foreign_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/compiler/dart2js_native/native_field_rename_1_frog_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/compiler/dart2js_native/native_field_rename_2_frog_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/compiler/dart2js_native/native_method_rename1_frog_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/compiler/dart2js_native/native_method_rename2_frog_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/compiler/dart2js_native/native_method_rename3_frog_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/compiler/dart2js_native/native_property_frog_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/copy_dart.py View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/dart2js/chrome_dart2js.darttemplate View 1 2 3 4 5 6 7 1 chunk +2 lines, -0 lines 0 comments Download
M tools/dom/templates/html/dart2js/html_dart2js.darttemplate View 1 2 3 4 5 6 7 8 1 chunk +3 lines, -0 lines 0 comments Download
M tools/dom/templates/html/dart2js/indexed_db_dart2js.darttemplate View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -0 lines 0 comments Download
M tools/dom/templates/html/dart2js/svg_dart2js.darttemplate View 1 2 3 4 5 6 7 8 1 chunk +3 lines, -0 lines 0 comments Download
M tools/dom/templates/html/dart2js/web_audio_dart2js.darttemplate View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Johnni Winther
7 years, 11 months ago (2013-01-16 13:35:21 UTC) #1
ngeoffray
LGTM!
7 years, 11 months ago (2013-01-16 16:02:52 UTC) #2
ahe
Wow! LGTM https://codereview.chromium.org/11973006/diff/1/sdk/lib/_internal/compiler/implementation/compiler.dart File sdk/lib/_internal/compiler/implementation/compiler.dart (right): https://codereview.chromium.org/11973006/diff/1/sdk/lib/_internal/compiler/implementation/compiler.dart#newcode514 sdk/lib/_internal/compiler/implementation/compiler.dart:514: cancel('core library does not contain required classes: ...
7 years, 11 months ago (2013-01-16 18:13:41 UTC) #3
Johnni Winther
PTAL Found a bug regarding package URIs and ended up cleaning up the use and ...
7 years, 11 months ago (2013-01-22 13:35:52 UTC) #4
Johnni Winther
7 years, 11 months ago (2013-01-22 13:42:28 UTC) #5 
Oops. Wrong CL, PTAL at https://codereview.chromium.org/11967010.

Powered by Google App Engine
This is Rietveld 408576698