Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1123)

Issue 11971026: Build the openglui embedder conditionally (Closed)

Created:
7 years, 11 months ago by vsm
Modified:
7 years, 11 months ago
Reviewers:
iposva, gram
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Build the openglui embedder conditionally To build the emulator_embedder, you'll need to set: GYP_DEFINES=enable_openglui=1 Committed: https://code.google.com/p/dart/source/detail?r=17234

Patch Set 1 #

Patch Set 2 : Fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M runtime/dart-runtime.gyp View 1 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
vsm
7 years, 11 months ago (2013-01-16 23:31:55 UTC) #1
gram
7 years, 11 months ago (2013-01-16 23:35:09 UTC) #2
lgtm, but do you want to add the samples dependency back in the top level gyp
too?

Powered by Google App Engine
This is Rietveld 408576698