Create IterableMixinWorkaround and move most of the Collections methods there.

Create IterableMixinWorkaround and move most of the Collections methods there.

Committed: https://code.google.com/p/dart/source/detail?r=17207
Reverted: https://code.google.com/p/dart/source/detail?r=17210

Committed: https://code.google.com/p/dart/source/detail?r=17213

[floitsch, 2013-01-16 14:45:32]

One reason to reject this CL would be that the 'where', 'mappedBy' functions in
IterableMixinWorkaround don't have the correct generic type anymore.

[Lasse Reichstein Nielsen, 2013-01-16 15:34:30]

LGTM.
It's a temporary workaround. I can live with being too 'dynamic' until we get
real mixins.

https://codereview.chromium.org/11971016/diff/1/sdk/lib/collection/collection...
File sdk/lib/collection/collections.dart (right):

https://codereview.chromium.org/11971016/diff/1/sdk/lib/collection/collection...
sdk/lib/collection/collections.dart:6: 
Add comment describing purpose of class.

https://codereview.chromium.org/11971016/diff/1/sdk/lib/collection/collection...
sdk/lib/collection/collections.dart:203: return new WhereIterable(iterable, f);
Just make the first argument be type "Iterable" with no <Object>. It's being
used as dynamic when passed to 'f' anyway.

https://codereview.chromium.org/11971016/diff/1/sdk/lib/collection/collection...
sdk/lib/collection/collections.dart:211: // TODO(floitsch): missing generic
type.
It's a workaround, it'll be fixed when we have mixins with type parameters.

[floitsch, 2013-01-16 16:11:35]

PTAL.
I added forwarder methods so I can commit today without breaking anybody.

https://codereview.chromium.org/11971016/diff/1/sdk/lib/collection/collection...
File sdk/lib/collection/collections.dart (right):

https://codereview.chromium.org/11971016/diff/1/sdk/lib/collection/collection...
sdk/lib/collection/collections.dart:6: 
On 2013/01/16 15:34:31, Lasse Reichstein Nielsen wrote:
> Add comment describing purpose of class.

Done.

https://codereview.chromium.org/11971016/diff/1/sdk/lib/collection/collection...
sdk/lib/collection/collections.dart:203: return new WhereIterable(iterable, f);
On 2013/01/16 15:34:31, Lasse Reichstein Nielsen wrote:
> Just make the first argument be type "Iterable" with no <Object>. It's being
> used as dynamic when passed to 'f' anyway.

Done.

https://codereview.chromium.org/11971016/diff/1/sdk/lib/collection/collection...
sdk/lib/collection/collections.dart:211: // TODO(floitsch): missing generic
type.
On 2013/01/16 15:34:31, Lasse Reichstein Nielsen wrote:
> It's a workaround, it'll be fixed when we have mixins with type parameters.

Replaced with normal comment.

[Lasse Reichstein Nielsen, 2013-01-17 13:53:33]

lgtm

[floitsch, 2013-01-17 14:36:20]

Fixed a typo in js_array.dart.
Resubmitting.