Issue 11970024: Simplify exception handler table

Issue 11970024: Simplify exception handler table (Closed)

Created:
7 years, 11 months ago by hausner

Modified:
7 years, 11 months ago

Reviewers:
siva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Simplify exception handler table Sort entries and drop the try_index field. This simplifies lookup of exception handlers when walking the traces on exceptions. Committed: https://code.google.com/p/dart/source/detail?r=17179

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+66 lines, -109 lines)			Patch
M	runtime/vm/code_descriptors.h	View		3 chunks	+20 lines, -25 lines	0 comments	Download
M	runtime/vm/debugger.cc	View		3 chunks	+2 lines, -17 lines	0 comments	Download
M	runtime/vm/object.h	View		1 chunk	+6 lines, -8 lines	0 comments	Download
M	runtime/vm/object.cc	View		3 chunks	+20 lines, -29 lines	0 comments	Download
M	runtime/vm/object_test.cc	View	1	2 chunks	+8 lines, -11 lines	0 comments	Download
M	runtime/vm/raw_object.h	View	1	1 chunk	+4 lines, -3 lines	0 comments	Download
M	runtime/vm/stack_frame.cc	View		1 chunk	+6 lines, -16 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

siva

LGTM. Nice simplification. https://codereview.chromium.org/11970024/diff/1/runtime/vm/object_test.cc File runtime/vm/object_test.cc (right): https://codereview.chromium.org/11970024/diff/1/runtime/vm/object_test.cc#newcode2741 runtime/vm/object_test.cc:2741: exception_handlers.SetHandlerInfo(3, 1, 150); kNumEntries is 6 ...

7 years, 11 months ago (2013-01-17 00:37:39 UTC) #2

hausner

7 years, 11 months ago (2013-01-17 01:05:55 UTC) #3

Thank you.

https://codereview.chromium.org/11970024/diff/1/runtime/vm/object_test.cc
File runtime/vm/object_test.cc (right):

https://codereview.chromium.org/11970024/diff/1/runtime/vm/object_test.cc#new...
runtime/vm/object_test.cc:2741: exception_handlers.SetHandlerInfo(3, 1, 150);
On 2013/01/17 00:37:39, siva wrote:
> kNumEntries is 6 but only 4 entries are being populated
> can kNumEntries be 4 now?

Done.

https://codereview.chromium.org/11970024/diff/1/runtime/vm/raw_object.h
File runtime/vm/raw_object.h (right):

https://codereview.chromium.org/11970024/diff/1/runtime/vm/raw_object.h#newco...
runtime/vm/raw_object.h:862: struct HandlerInfo {
On 2013/01/17 00:37:39, siva wrote:
> We should add a comment here that the index in the table corresponds to the
try
> block index of the handler.

Done.

Expand Messages | Collapse Messages