Issue 11970019: Change /// @docsEditable to @DocsEditable annotation.

Issue 11970019: Change /// @docsEditable to @DocsEditable annotation. (Closed)

Created:
7 years, 11 months ago by Andrei Mouravski

Modified:
7 years, 11 months ago

Reviewers:
blois

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Change /// @docsEditable to @DocsEditable annotation. Committed: https://code.google.com/p/dart/source/detail?r=17171

Patch Set 2 : Removed dead methods. #

Total comments: 8

Patch Set 3 : Template removal stuff. #

Created: 7 years, 11 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9921 lines, -8078 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View		510 chunks	+3122 lines, -4765 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View		567 chunks	+3328 lines, -469 lines	0 comments	Download
M	sdk/lib/html/html_common/metadata.dart	View	1 2	1 chunk	+7 lines, -0 lines	0 comments	Download
M	sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart	View	1 2	43 chunks	+160 lines, -221 lines	0 comments	Download
M	sdk/lib/indexed_db/dartium/indexed_db_dartium.dart	View	1 2	44 chunks	+149 lines, -26 lines	0 comments	Download
M	sdk/lib/svg/dart2js/svg_dart2js.dart	View	1 2	187 chunks	+1323 lines, -2183 lines	0 comments	Download
M	sdk/lib/svg/dartium/svg_dartium.dart	View	1 2	183 chunks	+1472 lines, -91 lines	0 comments	Download
M	sdk/lib/web_audio/dart2js/web_audio_dart2js.dart	View	1 2	33 chunks	+169 lines, -250 lines	0 comments	Download
M	sdk/lib/web_audio/dartium/web_audio_dartium.dart	View	1 2	40 chunks	+181 lines, -6 lines	0 comments	Download
M	tools/dom/scripts/generator.py	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download
M	tools/dom/scripts/htmldartgenerator.py	View	1 2	4 chunks	+2 lines, -30 lines	0 comments	Download
M	tools/dom/scripts/htmleventgenerator.py	View	1 2	2 chunks	+3 lines, -3 lines	0 comments	Download
M	tools/dom/scripts/systemhtml.py	View	1 2	4 chunks	+0 lines, -5 lines	0 comments	Download
M	tools/dom/templates/dart2js_impl.darttemplate	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/dom/templates/html/dart2js/impl_Console.darttemplate	View	1 2	1 chunk	+0 lines, -21 lines	0 comments	Download
M	tools/dom/templates/html/dart2js/impl_Navigator.darttemplate	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
M	tools/dom/templates/html/dart2js/impl_Window.darttemplate	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
M	tools/dom/templates/html/impl/impl_HTMLInputElement.darttemplate	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
M	tools/dom/templates/html/impl/impl_History.darttemplate	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/dom/templates/html/impl/pure_interface.darttemplate	View	1 2	1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

blois

https://codereview.chromium.org/11970019/diff/9002/tools/dom/templates/html/dart2js/impl_Console.darttemplate File tools/dom/templates/html/dart2js/impl_Console.darttemplate (left): https://codereview.chromium.org/11970019/diff/9002/tools/dom/templates/html/dart2js/impl_Console.darttemplate#oldcode28 tools/dom/templates/html/dart2js/impl_Console.darttemplate:28: /// @docsEditable true Should not have docseditable for any ...

7 years, 11 months ago (2013-01-16 21:07:40 UTC) #2

Andrei Mouravski

PTAL. https://codereview.chromium.org/11970019/diff/9002/tools/dom/templates/html/dart2js/impl_Console.darttemplate File tools/dom/templates/html/dart2js/impl_Console.darttemplate (left): https://codereview.chromium.org/11970019/diff/9002/tools/dom/templates/html/dart2js/impl_Console.darttemplate#oldcode28 tools/dom/templates/html/dart2js/impl_Console.darttemplate:28: /// @docsEditable true On 2013/01/16 21:07:40, blois wrote: ...

7 years, 11 months ago (2013-01-16 21:11:18 UTC) #3

lgtm

Expand Messages | Collapse Messages