Optimized loads/stores for scalar list: Uint8Clamped, Int8, Int16, Uint16.

Optimized loads/stores for scalar list: Uint8Clamped, Int8, Int16, Uint16.

This CL adds optimized stores for Uint8ClampedList, and
loads+stores for Int8List, Int16List and Uint16List.


TEST=tests/standalone/byte_array_test.dart, tests/standalone/int_array_test.dart
Committed: https://code.google.com/p/dart/source/detail?r=17190

[Florian Schneider, 2013-01-16 15:11:13]

[+vm-dev]

[srdjan, 2013-01-16 17:47:33]

LGTM

https://codereview.chromium.org/11967012/diff/2001/runtime/vm/flow_graph_comp...
File runtime/vm/flow_graph_compiler.cc (right):

https://codereview.chromium.org/11967012/diff/2001/runtime/vm/flow_graph_comp...
runtime/vm/flow_graph_compiler.cc:1059: return
ExternalUint8Array::kBytesPerElement;
Can you add kExternalUint8ClampedArrayCid as well. It turns out that is the one
that we will be getting from Canvas.

https://codereview.chromium.org/11967012/diff/2001/runtime/vm/intermediate_la...
File runtime/vm/intermediate_language_ia32.cc (right):

https://codereview.chromium.org/11967012/diff/2001/runtime/vm/intermediate_la...
runtime/vm/intermediate_language_ia32.cc:1244: : Location::RequiresRegister());
SInce index gets untagged, do you need writable register?

https://codereview.chromium.org/11967012/diff/2001/runtime/vm/intermediate_la...
runtime/vm/intermediate_language_ia32.cc:1259: case kUint16ArrayCid:
Add a comment why a writable register.

https://codereview.chromium.org/11967012/diff/2001/tests/standalone/int_array...
File tests/standalone/int_array_test.dart (right):

https://codereview.chromium.org/11967012/diff/2001/tests/standalone/int_array...
tests/standalone/int_array_test.dart:131: for (int i = 0; i < 10000; i++) {
Why 10000? 2000 should be plenty to trigger compilation.

[Florian Schneider, 2013-01-17 10:27:14]

https://codereview.chromium.org/11967012/diff/2001/runtime/vm/flow_graph_comp...
File runtime/vm/flow_graph_compiler.cc (right):

https://codereview.chromium.org/11967012/diff/2001/runtime/vm/flow_graph_comp...
runtime/vm/flow_graph_compiler.cc:1059: return
ExternalUint8Array::kBytesPerElement;
On 2013/01/16 17:47:33, srdjan wrote:
> Can you add kExternalUint8ClampedArrayCid as well. It turns out that is the
one
> that we will be getting from Canvas.

Yes, of course. I will add the external array operations in a separate CL.

https://codereview.chromium.org/11967012/diff/2001/runtime/vm/intermediate_la...
File runtime/vm/intermediate_language_ia32.cc (right):

https://codereview.chromium.org/11967012/diff/2001/runtime/vm/intermediate_la...
runtime/vm/intermediate_language_ia32.cc:1244: : Location::RequiresRegister());
On 2013/01/16 17:47:33, srdjan wrote:
> SInce index gets untagged, do you need writable register?

The smi index either gets retagged at the end (element size == 1) or it is left
smi tagged (for all element sizes > 1). I'll add a comment.

I'm thinking about changing this though: If we add a constraint
WritableRegisterOrConstant, we can avoid the tagging the index again completely.

https://codereview.chromium.org/11967012/diff/2001/runtime/vm/intermediate_la...
runtime/vm/intermediate_language_ia32.cc:1259: case kUint16ArrayCid:
On 2013/01/16 17:47:33, srdjan wrote:
> Add a comment why a writable register.

Done.

https://codereview.chromium.org/11967012/diff/2001/tests/standalone/int_array...
File tests/standalone/int_array_test.dart (right):

https://codereview.chromium.org/11967012/diff/2001/tests/standalone/int_array...
tests/standalone/int_array_test.dart:131: for (int i = 0; i < 10000; i++) {
On 2013/01/16 17:47:33, srdjan wrote:
> Why 10000? 2000 should be plenty to trigger compilation.

Done.