Issue 1196323002: Fix a bug in dart2js's shrinking reductions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1196323002: Fix a bug in dart2js's shrinking reductions. (Closed)

Created:
5 years, 6 months ago by Kevin Millikin (Google)

Modified:
5 years, 6 months ago

Reviewers:
asgerf

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fix a bug in dart2js's shrinking reductions. When a term is deleted, the algorithm searches for new redexes created by the term's deletion. Continuation beta redexes search up the term between the redex and the continuation's binding to ensure that the continuation is not moved into the scope of an exception handler. This search fails if it first encounters the root of the deleted subterm (i.e., the newly-created redex is in the deleted term). Just ignore the redex in that case, since the term is being deleted. Also, update some triaged test expectations with their bug numbers. R=asgerf@google.com Committed: https://github.com/dart-lang/sdk/commit/7a853ca634e9ffbbc641ad0adbde8a8d9e776351

Patch Set 1 #

Patch Set 2 : Merge. #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -4 lines)			Patch
M	pkg/compiler/lib/src/cps_ir/shrinking_reductions.dart	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	pkg/pkg.status	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/compiler/dart2js_extra/dart2js_extra.status	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/language/language_dart2js.status	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

asgerf

LGTM. Btw isn't there a way to implement this pass without a worklist? Analyzing first ...

5 years, 6 months ago (2015-06-22 14:36:01 UTC) #3

Kevin Millikin (Google)

5 years, 6 months ago (2015-06-22 14:50:59 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
7a853ca634e9ffbbc641ad0adbde8a8d9e776351 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages