Issue 11962036: Fix a bug with store-to-load forwarding for typed arrays.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11962036: Fix a bug with store-to-load forwarding for typed arrays. (Closed)

Created:
7 years, 11 months ago by Florian Schneider

Modified:
7 years, 11 months ago

Reviewers:
Vyacheslav Egorov (Google)

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix a bug with store-to-load forwarding for typed arrays. Stores to typed arrays implicitly convert the value stored. This CL disables store-to-load forwarding for these array stores. Normal arrays and float64 arrays can be still optimized as before (no conversion occurs on store) TEST=tests/language/int_array_load_elimination_test.dart Committed: https://code.google.com/p/dart/source/detail?r=17208

Patch Set 1 #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -7 lines)			Patch
	M	runtime/vm/flow_graph_optimizer.cc	View		1 chunk	+15 lines, -7 lines	0 comments	Download
	A	tests/language/int_array_load_elimination_test.dart	View		1 chunk	+20 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages