Issue 11961013: Fix bug in the x64 assembler's movw instruction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11961013: Fix bug in the x64 assembler's movw instruction. (Closed)

Created:
7 years, 11 months ago by Florian Schneider

Modified:
7 years, 11 months ago

Reviewers:
Vyacheslav Egorov (Google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix bug in the x64 assembler's movw instruction. The order of prefixes was wrong. The operand size prefix (0x66) must occur before the REX prefix. From the instruction set reference: [...]the REX prefix byte must immediately precede the opcode byte or the escape opcode byte (0FH). [...] Also, make movw(reg, addr) unavailable, consistent with ia32. TEST=runtime/vm/assembler_x64_test.cc Committed: https://code.google.com/p/dart/source/detail?r=17135

Patch Set 1 #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -6 lines)			Patch
	M	runtime/vm/assembler_x64.cc	View		1 chunk	+2 lines, -6 lines	0 comments	Download
	M	runtime/vm/assembler_x64_test.cc	View		1 chunk	+37 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages