Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(635)

Issue 11960005: Move sort to collection-dev and remove coreSort. (Closed)

Created:
7 years, 11 months ago by floitsch
Modified:
7 years, 11 months ago
CC:
reviews_dartlang.org, Anders Johnsen
Visibility:
Public.

Description

Move sort to collection-dev and remove coreSort. Committed: https://code.google.com/p/dart/source/detail?r=17296

Patch Set 1 #

Patch Set 2 : Adapt for not moving IterableMixinWorkaround. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -369 lines) Patch
M runtime/lib/array.dart View 1 1 chunk +1 line, -2 lines 0 comments Download
M runtime/lib/byte_array.dart View 1 2 chunks +2 lines, -4 lines 0 comments Download
M runtime/lib/growable_array.dart View 1 1 chunk +1 line, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/lib/js_array.dart View 1 1 chunk +1 line, -2 lines 0 comments Download
M sdk/lib/collection/collection.dart View 1 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/collection/collection_sources.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/collection/collections.dart View 1 1 chunk +5 lines, -0 lines 0 comments Download
A + sdk/lib/collection/sort.dart View 1 1 chunk +1 line, -7 lines 0 comments Download
M sdk/lib/core/core.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/core/corelib_sources.gypi View 1 chunk +0 lines, -1 line 0 comments Download
D sdk/lib/core/sort.dart View 1 chunk +0 lines, -350 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
floitsch
Move sorting functions to collection-dev. Remove coreSort and replace it with IterableMixinWorkaround.sortList.
7 years, 11 months ago (2013-01-17 19:26:49 UTC) #1
Lasse Reichstein Nielsen
lgtm
7 years, 11 months ago (2013-01-18 11:41:13 UTC) #2
floitsch
7 years, 11 months ago (2013-01-18 17:20:34 UTC) #3
Moved this CL in front of moving the IterableMixinWorkaround-change (which is on
hold).

Powered by Google App Engine
This is Rietveld 408576698