Issue 11959030: Fix two issues that broke minification on dart2js.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11959030: Fix two issues that broke minification on dart2js. (Closed)

Created:
7 years, 11 months ago by erikcorry

Modified:
7 years, 10 months ago

Reviewers:
karlklose

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix two issues that broke minification on dart2js. R=karlklose@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=17188

Patch Set 1 #

Total comments: 1

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -5 lines)			Patch
	M	sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	sdk/lib/_internal/compiler/implementation/lib/js_helper.dart	View		2 chunks	+9 lines, -4 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ahe

7 years, 10 months ago (2013-02-13 12:54:07 UTC) #3

Message was sent while issue was closed.

https://codereview.chromium.org/11959030/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/lib/js_helper.dart (right):

https://codereview.chromium.org/11959030/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/lib/js_helper.dart:908: JS('void',
'#.dartException = #', this, dartException);
Sorry about that, I didn't think too carefully about this.

Expand Messages | Collapse Messages