Issue 11959012: Add dart:collection_dev library.

Issue 11959012: Add dart:collection_dev library. (Closed)

Created:
7 years, 11 months ago by floitsch

Modified:
7 years, 11 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, Anders Johnsen, Lasse Reichstein Nielsen

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add dart:collection_dev library. Committed: https://code.google.com/p/dart/source/detail?r=17263 Reverted: https://code.google.com/p/dart/source/detail?r=17265 Committed: https://code.google.com/p/dart/source/detail?r=17269

Patch Set 2 : Rename dart:collection_dev to dart:collection-dev. #

Patch Set 3 : Rebase after revert #

Patch Set 4 : Update create_sdk script. #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+123 lines, -6 lines)			Patch
M	runtime/vm/bootstrap.h	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/bootstrap.cc	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download
M	runtime/vm/bootstrap_nocorelib.cc	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	runtime/vm/object.h	View	1 2	2 chunks	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/object.cc	View	1 2	4 chunks	+28 lines, -0 lines	0 comments	Download
M	runtime/vm/object_store.h	View		2 chunks	+8 lines, -0 lines	0 comments	Download
M	runtime/vm/vm.gypi	View		4 chunks	+60 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/libraries.dart	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
A +	sdk/lib/collection_dev/collection_dev.dart	View	1	1 chunk	+1 line, -3 lines	0 comments	Download
A +	sdk/lib/collection_dev/collection_dev_sources.gypi	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
A +	sdk/lib/collection_dev/empty.dart	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	sdk/lib/core/core.dart	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/create_sdk.py	View	1 2 3	2 chunks	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

As far as I can see, this is importable from any script now?

7 years, 11 months ago (2013-01-16 15:56:25 UTC) #2

floitsch

On 2013/01/16 15:56:25, Anders Johnsen wrote: > As far as I can see, this is ...

7 years, 11 months ago (2013-01-16 16:12:10 UTC) #3

Lasse Reichstein Nielsen

lgtm https://codereview.chromium.org/11959012/diff/1/sdk/lib/_internal/libraries.dart File sdk/lib/_internal/libraries.dart (right): https://codereview.chromium.org/11959012/diff/1/sdk/lib/_internal/libraries.dart#newcode31 sdk/lib/_internal/libraries.dart:31: "collection_dev": const LibraryInfo("collection_dev/collection_dev.dart"), I prefer "collection-dev" as name. ...

7 years, 11 months ago (2013-01-17 13:59:22 UTC) #4

floitsch

https://codereview.chromium.org/11959012/diff/1/sdk/lib/_internal/libraries.dart File sdk/lib/_internal/libraries.dart (right): https://codereview.chromium.org/11959012/diff/1/sdk/lib/_internal/libraries.dart#newcode31 sdk/lib/_internal/libraries.dart:31: "collection_dev": const LibraryInfo("collection_dev/collection_dev.dart"), On 2013/01/17 13:59:22, Lasse Reichstein Nielsen ...

7 years, 11 months ago (2013-01-17 16:25:55 UTC) #5

floitsch

@Ivan: please check that the VM and gyp changes are ok.

7 years, 11 months ago (2013-01-17 16:27:03 UTC) #6

floitsch

7 years, 11 months ago (2013-01-18 13:07:07 UTC) #8

Needed to update the create_sdk script.
Resubmitting.

Wrt the name: we are going to hide the library soon. Kasper therefore suggested
to keep thinking until then and decide on the name at that point.

Expand Messages | Collapse Messages