Issue 11959011: Fix Path.relativeTo in special case where base is a substring of this.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11959011: Fix Path.relativeTo in special case where base is a substring of this. (Closed)

Created:
7 years, 11 months ago by Bill Hesse

Modified:
7 years, 11 months ago

Reviewers:
Mads Ager (google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Fix Path.relativeTo in special case where base is a substring of this. BUG= Committed: https://code.google.com/p/dart/source/detail?r=17145

Total comments: 2

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+73 lines, -62 lines)			Patch
M	sdk/lib/_internal/dartdoc/lib/dartdoc.dart	View		1 chunk	+1 line, -14 lines	0 comments	Download
M	sdk/lib/io/path_impl.dart	View	1	1 chunk	+52 lines, -48 lines	0 comments	Download
M	tests/standalone/io/path_test.dart	View	1	1 chunk	+20 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

Bill Hesse

This keeps the optimization of a.relativeTo(base) in the case that base is prefix of a, ...

7 years, 11 months ago (2013-01-16 15:30:25 UTC) #1

LGTM