Path fix for data-driving formatting tests.

Path fix for data-driving formatting tests.

R=brianwilkerson@google.com, kustermann@google.com

Committed: https://code.google.com/p/dart/source/detail?r=31445

[pquitslund, 2013-12-19 22:55:28]

Is there a safer way to access files from test scripts?  Maybe an environment
variable for the SDK dir? I don't like how this bakes in the assumption that
tests are run from the dart/ dir but I see there's precedent elsewhere
(tests/standalone/io/file_input_stream_test.dart for example).

Anyway, if you have better ideas, I'm all ears.

Thanks!

[kustermann, 2014-01-02 10:22:00]

Making assumptions (e.g. about current working directory) is not a good idea, I
agree.

We sometimes do have a environment variable for the SDK. But you're looking for
the dart repository root (or rather dart/pkg/analyzer) and *not* for the SDK.

See comments.

https://codereview.chromium.org/119583002/diff/1/pkg/analyzer/test/services/f...
File pkg/analyzer/test/services/formatter_test.dart (right):

https://codereview.chromium.org/119583002/diff/1/pkg/analyzer/test/services/f...
pkg/analyzer/test/services/formatter_test.dart:15: const TEST_DATA_DIR =
'pkg/analyzer/test/services/data';
You should not use forward slashes, windows uses backwards slashes and the "new
File()" constructor takes a native path AFAIK.

https://codereview.chromium.org/119583002/diff/1/pkg/analyzer/test/services/f...
pkg/analyzer/test/services/formatter_test.dart:1316: var testFile = new
File('$TEST_DATA_DIR/$testFileName');
Since you import 'dart:io' anyway, you could use dart:io's Platform.script (i.e.
take the Platform.script Uri drop the last path components until you see
"pkg/analyzer" at the end and then navigate to the data directory).

[pquitslund, 2014-01-02 18:39:11]

Thanks for the pointers.  The Platform.script angle is a good one.

Cheers!

https://codereview.chromium.org/119583002/diff/1/pkg/analyzer/test/services/f...
File pkg/analyzer/test/services/formatter_test.dart (right):

https://codereview.chromium.org/119583002/diff/1/pkg/analyzer/test/services/f...
pkg/analyzer/test/services/formatter_test.dart:15: const TEST_DATA_DIR =
'pkg/analyzer/test/services/data';
On 2014/01/02 10:22:00, kustermann wrote:
> You should not use forward slashes, windows uses backwards slashes and the
"new
> File()" constructor takes a native path AFAIK.

Ah, yes.  I mistakenly thought that the new File constructor was more magical. 
As per your advice below, I'm taking a different approach now, based on
Platform.script so this is moot.

https://codereview.chromium.org/119583002/diff/1/pkg/analyzer/test/services/f...
pkg/analyzer/test/services/formatter_test.dart:1316: var testFile = new
File('$TEST_DATA_DIR/$testFileName');
On 2014/01/02 10:22:00, kustermann wrote:
> Since you import 'dart:io' anyway, you could use dart:io's Platform.script
(i.e.
> take the Platform.script Uri drop the last path components until you see
> "pkg/analyzer" at the end and then navigate to the data directory).
> 

Perfect. Great idea!

[pquitslund, 2014-01-02 18:42:04]

File path resolution hardened...  PTAL.

Thanks!

[Brian Wilkerson, 2014-01-02 18:57:33]

LGTM

[kustermann, 2014-01-03 09:29:29]

LGTM

[pquitslund, 2014-01-03 19:40:56]

Committed patchset #4 manually as r31445 (presubmit successful).