Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 11958041: Increase test coverage on ie9 (Closed)

Created:
7 years, 11 months ago by kustermann
Modified:
7 years, 9 months ago
Reviewers:
ricow1
CC:
reviews_dartlang.org, ahe
Visibility:
Public.

Description

Increase test coverage on ie9 Committed: https://code.google.com/p/dart/source/detail?r=19460

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tests/co19/co19-compiler.status View 1 chunk +1 line, -1 line 0 comments Download
M tests/co19/co19-dart2js.status View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
kustermann
We can commit this as soon as we restarted the buildbot.
7 years, 11 months ago (2013-01-17 15:10:03 UTC) #1
ricow1
LGTM Peter: just FYI https://codereview.chromium.org/11958041/diff/1/tests/co19/co19-dart2js.status File tests/co19/co19-dart2js.status (right): https://codereview.chromium.org/11958041/diff/1/tests/co19/co19-dart2js.status#newcode618 tests/co19/co19-dart2js.status:618: [ $compiler == dart2js && ...
7 years, 11 months ago (2013-01-17 15:22:35 UTC) #2
kustermann
https://codereview.chromium.org/11958041/diff/1/tests/co19/co19-dart2js.status File tests/co19/co19-dart2js.status (right): https://codereview.chromium.org/11958041/diff/1/tests/co19/co19-dart2js.status#newcode618 tests/co19/co19-dart2js.status:618: [ $compiler == dart2js && ($runtime == ff || ...
7 years, 11 months ago (2013-01-17 16:16:23 UTC) #3
kustermann
7 years, 9 months ago (2013-03-05 11:02:13 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r19460 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698