Do not track parameter types of closures, since closure calls can be generated during the emitter.

Do not track parameter types of closures, since closure calls can be generated during the emitter.
Committed: https://code.google.com/p/dart/source/detail?r=17134

[kasperl, 2013-01-16 11:54:46]

LGTM, but:

https://codereview.chromium.org/11958009/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/js_backend/backend.dart (right):

https://codereview.chromium.org/11958009/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/js_backend/backend.dart:488: if
(selector.name == Compiler.CALL_OPERATOR_NAME) {
Using == is kind of dangerous because it works for all types. Maybe add a helper
somewhere that looks something like this:

   bool isClosureCallName(SourceString name) {
     SourceString callName = Compiler.CALL_OPERATOR_NAME;
     return name == callName;
   }

That will give us warnings and checked-mode errors if we ever change the type of
selector.name to something that doesn't match the type of
Compiler.CALL_OPERATOR_NAME. This would also be very useful in the namer.

[ngeoffray, 2013-01-16 12:10:03]

Thanks Kasper.

https://codereview.chromium.org/11958009/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/js_backend/backend.dart (right):

https://codereview.chromium.org/11958009/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/js_backend/backend.dart:488: if
(selector.name == Compiler.CALL_OPERATOR_NAME) {
On 2013/01/16 11:54:46, kasperl wrote:
> Using == is kind of dangerous because it works for all types. Maybe add a
helper
> somewhere that looks something like this:
> 
>    bool isClosureCallName(SourceString name) {
>      SourceString callName = Compiler.CALL_OPERATOR_NAME;
>      return name == callName;
>    }
> 
> That will give us warnings and checked-mode errors if we ever change the type
of
> selector.name to something that doesn't match the type of
> Compiler.CALL_OPERATOR_NAME. This would also be very useful in the namer.

Good point. I added a Selector.isClosureCall for now that catches this.