Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 11956021: Removing redundant event streams. (Closed)

Created:
7 years, 11 months ago by blois
Modified:
7 years, 11 months ago
Reviewers:
sra1
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Removing redundant event streams. Basically removing the event stream providers from Document and Window for events which are also declared on Element. The streams themselves are still exposed, just that a single provider is now on Element. Also removed MediaElement events from Window, as they are duplicative and should be accessed via the MediaElement provider. I was also hoping that this would have some JS size benefits, but I'm not seeing any. BUG=7860 Committed: https://code.google.com/p/dart/source/detail?r=17229

Patch Set 1 #

Patch Set 2 : Suppressing events on classes which are ignored. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+236 lines, -769 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 7 chunks +82 lines, -378 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 7 chunks +82 lines, -378 lines 0 comments Download
M tools/dom/scripts/htmldartgenerator.py View 1 1 chunk +2 lines, -1 line 0 comments Download
M tools/dom/scripts/htmleventgenerator.py View 1 4 chunks +59 lines, -6 lines 0 comments Download
M tools/dom/scripts/htmlrenamer.py View 1 4 chunks +11 lines, -4 lines 0 comments Download
M tools/dom/scripts/systemhtml.py View 1 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
blois
7 years, 11 months ago (2013-01-16 19:49:49 UTC) #1
sra1
7 years, 11 months ago (2013-01-17 11:20:05 UTC) #2
You are not seeing any size benefit because

(1) const EventStreamProvider<Event>('abort');
is the same immutable object not matter how many times you write it out in full.

(2) The static const constants get 'inlined' to their values. (dart2js does
leave unreferenced names in the generated code but that should go away:
https://code.google.com/p/dart/issues/detail?id=7568)

Given (1) I'm not sure this CL is worthwhile, but EventStreamProviders ever need
to be non-const, it would be.

LGTM if you want to keep the explicit sharing.

Powered by Google App Engine
This is Rietveld 408576698